[pacman-dev] [PATCH 1/5] Fixed some innacuracies in the pactest README

Bryan Ischo bji-keyword-pacman.3644cb at www.ischo.com
Wed Jan 14 14:56:07 EST 2009

Xavier wrote:
> My first feeling was that removing this list was alright, for the
> reason Bryan gave.
> But I changed my mind, there are only a few options that makes sense
> to be specified there, there are some who don't make any sense, and
> maybe even some who shouldn't be modified at all, like the different
> paths.
> I think we could just have a look at our current examples to have a
> good list of the useful options to use in pactests.
> pactest/tests/remove030.py:self.option["HoldPkg"] = ["dummy"]
> pactest/tests/sync021.py:self.option["IgnorePkg"] = ["pkg2"]
> pactest/tests/sync120.py:self.option["IgnorePkg"] = ["pkg2"]
> pactest/tests/sync133.py:self.option["IgnorePkg"] = ["pkg1"]
> pactest/tests/sync138.py:self.option["IgnoreGroup"] = ["grp"]
> pactest/tests/sync301.py:self.option["SyncFirst"] = ["pacman"]
> pactest/tests/sync500.py:self.option["NoExtract"] = ["usr/man/man1/dummy.1"]
> pactest/tests/sync501.py:self.option["NoUpgrade"] = ["etc/dummy.conf"]
> pactest/tests/upgrade010.py:self.option["NoUpgrade"] = ["etc/dummy.conf"]
> pactest/tests/upgrade070.py:self.option["NoExtract"] = ["usr/man/man1/dummy.1"]
> pactest/tests/xfercommand001.py:self.option['XferCommand'] =
> ['/usr/bin/curl %u > %o']
> We could either just take the examples above for each option.
> Otherwise, we could list all these options and indicate the list could
> be incomplete :
> HoldPkg,IgnorePkg,IgnoreGroup,SyncFirst,NoExtract,NoUpgrade,XferCommand,...
> and then give an example for some of them.

OK, I can modify my patch according to this feedback.

What is the best way to do this?  Should I make a new patch assuming 
that my patch 1 was accepted and applied?  Or should I make a 
replacement patch 1 and send that out on the assumption that my other 
patch will not be applied?


More information about the pacman-dev mailing list