[pacman-dev] My new patches

Dan McGee dpmcgee at gmail.com
Fri Jan 16 20:56:13 EST 2009

On Fri, Jan 16, 2009 at 7:33 PM, Bryan Ischo
<bji-keyword-pacman.3644cb at www.ischo.com> wrote:
> The first three patches I just sent to the list encompass the new
> implementation of the IgnorePkg/IgnoreGroup behavior.  These changes are
> much smaller (although the addition of better documentation blocks makes
> them look bigger than they are in terms of code size) than my previous
> changes, but they accomplish the same thing (albeit slightly less
> efficiently in some cases).
> The last patch is the change to the pactest/README which incorporates
> feedback from the list.
> I tried to make these emails include the patches inline but I do not know if
> I was successful.  I used the command:
> git format-patch --signoff --stdout --inline HEAD^^^^ | git imap-send

Drop the --inline, this is completely misleading. From the manpage:

           Create multipart/mixed attachment, the first part of which is the
           commit message and the patch itself in the second part, with
           "Content-Disposition: inline".

> To generate the emails and get them to my IMAP server, from where I sent
> them.  In future I might use git send-email instead, I found it convenient
> to use git imap-send but if it doesn't produce properly inlined messages, I
> can switch to git send-email.

Try resending just your pactest README patch again- see if that works,
then send the rest. I will merge the pactest README fixes for sure,
the rest I will probably want to inline comment on if needed.


More information about the pacman-dev mailing list