[pacman-dev] [PATCH 1/2] makepkg: clean up test usage

Bryan Ischo bji-keyword-pacman.3644cb at www.ischo.com
Sun Jan 18 02:27:18 EST 2009


Allan McRae wrote:
>
> Looking into this further, it seems that the ABS guide always quotes 
> variables.  I.e. [ "$foobar" -eq 0 ].  Exceptions being $? and $#.  I 
> have tried to figure out what advantage this gives but can not find any.
>
> Allan

I think it's just generally good practice to quote variables because 
they could have spaces in them.  However, in the case of the -eq 
operation, anything other than a single integer with no spaces will 
produce an error anyway.

I think it's just a good habit to be in, to quote variables, even if the 
specific instance doesn't actually call for it.

Bryan



More information about the pacman-dev mailing list