[pacman-dev] [PATCH 1/2] makepkg: clean up test usage
dpmcgee at gmail.com
Sun Jan 18 12:29:15 EST 2009
On Sun, Jan 18, 2009 at 1:27 AM, Bryan Ischo
<bji-keyword-pacman.3644cb at www.ischo.com> wrote:
> Allan McRae wrote:
>> Looking into this further, it seems that the ABS guide always quotes
>> variables. I.e. [ "$foobar" -eq 0 ]. Exceptions being $? and $#. I have
>> tried to figure out what advantage this gives but can not find any.
> I think it's just generally good practice to quote variables because they
> could have spaces in them. However, in the case of the -eq operation,
> anything other than a single integer with no spaces will produce an error
> I think it's just a good habit to be in, to quote variables, even if the
> specific instance doesn't actually call for it.
I'd be fine with leaving the quotes and just changing to the '-eq'
operator. We definitely don't need the quotes around "0" and "1"
More information about the pacman-dev