[pacman-dev] [PATCH] Refactor do/while cycle and multiple while cycles

Xavier shiningxc at gmail.com
Thu Nov 12 19:15:52 EST 2009


On Fri, Nov 13, 2009 at 12:59 AM, Laszlo Papp <djszapi2 at gmail.com> wrote:
> * It makes the code clearer to read/understand
> * Cppcheck tool doesn't show this anymore: [./util.c:215]: (error) Resource leak: fd
> ---
>  lib/libalpm/trans.c |    5 ++++-
>  lib/libalpm/util.c  |   11 +++++++----
>  src/pacman/pacman.c |    4 +++-
>  3 files changed, 14 insertions(+), 6 deletions(-)
>

The 6th iteration of this trivial patch looks good to me.

Thanks for your hard work :)


More information about the pacman-dev mailing list