[pacman-dev] [PATCH] Refactor do/while cycle and multiple while cycles

Laszlo Papp djszapi at archlinux.us
Mon Nov 16 03:11:30 EST 2009


On Fri, Nov 13, 2009 at 1:15 AM, Xavier <shiningxc at gmail.com> wrote:
> On Fri, Nov 13, 2009 at 12:59 AM, Laszlo Papp <djszapi2 at gmail.com> wrote:
>> * It makes the code clearer to read/understand
>> * Cppcheck tool doesn't show this anymore: [./util.c:215]: (error) Resource leak: fd
>> ---
>>  lib/libalpm/trans.c |    5 ++++-
>>  lib/libalpm/util.c  |   11 +++++++----
>>  src/pacman/pacman.c |    4 +++-
>>  3 files changed, 14 insertions(+), 6 deletions(-)
>>
>
> The 6th iteration of this trivial patch looks good to me.
>
> Thanks for your hard work :)
>
>

Okay, Dan applied it, thank you the helps Xavier, really.

Best Regards,
Laszlo Papp


More information about the pacman-dev mailing list