[pacman-dev] [PATCH] compute package download size outside _alpm_sync_prepare

Jonathan Conder j at skurvy.no-ip.org
Thu May 6 05:29:40 CEST 2010

On Thu, 2010-05-06 at 01:33 +0200, Nagy Gabor wrote:
> Personally I prefer the old patch over this. If I read this patch
> correctly, you have completely removed the on-demand computation from
> current pacman GUI. The old patch was better for -Sp for example...

You can still do on-demand computation with alpm_pkg_download_size.
_alpm_sync_commit does not use this because they are guaranteed to be
valid by _alpm_sync_prepare (and I wanted to make as few changes as
possible this time round).

> I think we should catch the PM_ERR_PKG_INVALID_NAME error outside of
> compute_download_size().

Maybe that would prevent mistakes like mine in the future, but really I
should not have overlooked the return code of compute_download_size.


More information about the pacman-dev mailing list