[pacman-dev] [PATCH 1/5] Tests: Adjust sync023 to correctly test FS#20221

[Dan McGee]

On Sat, Sep 25, 2010 at 4:40 AM, Jakob Gruber <jakob.gruber at gmail.com> wrote:
> FS#20221
^^ unnecessary text here. :)

>
> Issue: calling pacman with '-S --needed <group>', <group> has
> <pkg1> in more than one repo. <pkg1> is version 1.1 locally, version 1.1
> in an earlier repo (for example testing), and 1.0 in a later repo (for
> example core).
>
> Example: <group> is base-devel
> make in testing is 1.1
> make in core is 1.0
> make installed locally is 1.1
>
> pacman used to correctly skip make in testing (because versions match),
> but then try to downgrade to 1.0 (versions do NOT match).
>
> This test did not correctly check this scenario.

Should this just be a different test completely? You seemed to have
changed both the setup and subsequent checks but didn't preserve the
original checks.

-Dan

> Signed-off-by: Jakob Gruber <jakob.gruber at gmail.com>
> ---
>  test/pacman/tests/sync023.py |    7 ++++---
>  1 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/test/pacman/tests/sync023.py b/test/pacman/tests/sync023.py
> index 8233ab7..1bf0a0f 100644
> --- a/test/pacman/tests/sync023.py
> +++ b/test/pacman/tests/sync023.py
> @@ -5,9 +5,9 @@
>  lp3 = pmpkg("pkg3")
>
>  sp1 = pmpkg("pkg1")
> -sp2 = pmpkg("pkg2")
> +sp2 = pmpkg("pkg2", "1.2-1")
>  sp3 = pmpkg("pkg3")
> -newp1 = pmpkg("pkg1", "1.1-1")
> +newp1 = pmpkg("pkg1", "1.2-1")
>
>  for p in lp1, lp2, lp3, sp1, sp2, sp3, newp1:
>        setattr(p, "groups", ["grp"])
> @@ -26,4 +26,5 @@
>  for p in sp1, sp2, sp3:
>        self.addrule("PKG_EXIST=%s" % p.name)
>  # The newer version should still be installed
> -self.addrule("PKG_VERSION=pkg1|1.1-1")
> +self.addrule("PKG_VERSION=pkg1|1.2-1")
> +self.addrule("PKG_VERSION=pkg2|1.2-1")
> --
> 1.7.3
>
>
>