[pacman-dev] [PATCH 1/5] Tests: Adjust sync023 to correctly test FS#20221

[Jakob Gruber]

  On 09/27/2010 05:29 PM, Dan McGee wrote:
> On Sat, Sep 25, 2010 at 4:40 AM, Jakob Gruber<jakob.gruber at gmail.com>  wrote:
>> FS#20221
> ^^ unnecessary text here. :)
>
This is the related bug report. It does look kinda odd in the all by 
itself in the first line though :)
>> Issue: calling pacman with '-S --needed<group>',<group>  has
>> <pkg1>  in more than one repo.<pkg1>  is version 1.1 locally, version 1.1
>> in an earlier repo (for example testing), and 1.0 in a later repo (for
>> example core).
>>
>> Example:<group>  is base-devel
>> make in testing is 1.1
>> make in core is 1.0
>> make installed locally is 1.1
>>
>> pacman used to correctly skip make in testing (because versions match),
>> but then try to downgrade to 1.0 (versions do NOT match).
>>
>> This test did not correctly check this scenario.
> Should this just be a different test completely? You seemed to have
> changed both the setup and subsequent checks but didn't preserve the
> original checks.
>
> -Dan

I couldn't see how the original test made any sense, so I adjusted it to 
test FS#20221 (as specified in commit 
e702f56ea671c6cd1154a0ddb41fa63e97587c85).

The old PKG_EXIST rules do nothing because pkg{1,2,3} are created in 
both the local repo and the sync repo.

Likewise, the old PKG_VERSION rule has no effect because pkg1 is version 
1.1-1 in all (local, sync, testing) repos.

So the only thing it actually tests is that '-S --needed grp' runs 
without errors, and my updated test also checks for that.

Or did I miss something? If you'd still like to have it as a separate 
test, let me know.