[pacman-dev] [PATCH 1/4] pacman-key.sh.in: applied patch by Denis A. Altoé Falqueto

[Dan McGee]

On Wed, Apr 20, 2011 at 12:56 AM, Rémy Oudompheng
<remyoudompheng at gmail.com> wrote:
> On Tue 19 April 2011 at 23:19 +0300, ivan.kanak at gmail.com wrote:
>> From: Ivan Kanakarakis <ivan.kanak at gmail.com>
>>
>> Denis' patch applied to master
>>
>> ---
>>  scripts/pacman-key.sh.in |  520 ++++++++++++++++++++++++---------------------
>>  1 files changed, 277 insertions(+), 243 deletions(-)
>>
>
> Hello,
>
> This patch seems to apply random whitespace changes over all the file.
> Could you resend it without the whitespace changes so that it is easier
> to see what has changed?

More to the point- this patch has an awful commit message, as do the
others in the series, so I won't look at them until that is fixed.

1. I don't know what is even being done by this (see the subject), and
the commit message helps less- it needs to be a paragraph summary of
what you are trying to accomplish.
2. Please use sentences, paragraphs, capital letters, and punctuation
around here.

http://www.archlinux.org/pacman/submitting-patches.html

-Dan