[pacman-dev] Removing empty directories

Allan McRae allan at archlinux.org
Sun Feb 27 07:41:49 EST 2011


On 27/02/11 21:48, Xavier Chantry wrote:
> On Sun, Feb 27, 2011 at 12:40 PM, Allan McRae<allan at archlinux.org>  wrote:
>>
>> How much of a performance hit would there really be?   If I have this right
>> in my head (big assumption), the file-lists for all packages are read in in
>> one go.  So all that we would have to do is loop over them checking for the
>> empty directory before we add it to the removal list. Should be a minimal
>> impact....  maybe...
>>
>> I suppose the best way is to make a patch and see!
>>
>
> AFAIK the file lists currently do not need to be loaded with -R, so
> the impact would be loading them more than the checking itself.
> Then again, we have that cost for all -S operation already, so why not
> make -R as bad ? :)

strace tells me that I was wrong and you are right.  So that is big 
overhead...

> Anyway we will keep having problems until we have a single file for
> the local db as well.

Yes, we will.  I might attempt to a gathering of the contenders for 
improving this post 3.5.

Allan


More information about the pacman-dev mailing list