[pacman-dev] [PATCH 00/11] Support VCS URLs.

Dave Reisner d at falconindy.com
Thu Jul 12 11:15:59 EDT 2012


On Thu, Jul 12, 2012 at 05:04:52PM +0200, Thomas Bächler wrote:
> Am 27.06.2012 00:58, schrieb Allan McRae:
> > At the request of Dave, here are the updated versions of patches sent to the
> > list earlier.
> > 
> > Support for the following needs readded: CVS, Mercurial, Darcs and Bazaar
> > 
> > Known issue: the pkgver check needs adjusted when using an auto-updating pkgver
> 
> I've used the code from your vcs branch for a bit and it worked quite
> well for me with git sources. It is also incredibly useful compared to
> the old implementation.
> 
> One weird bug: I used a pkgver function like this:
> 
> pkgver() {
>   local myver
> 
>   ...
> }
> 
> This failed on the 'myver' variable name, although it is local.
> 

Just as I told you in IRC, the debug log showed that you're trying to
stomp on a read-only var. bash will not let you do this even if its
scoped to a function. We could probably change the name of this var,
e.g. to "makepkg_version", instead of something so foolishly generic.

d


More information about the pacman-dev mailing list