[pacman-dev] [PATCH 2/2] Use the 'configure'd PYTHON to run pactest.

[Andrew Gregory]

On 12/19/13 at 03:31pm, Jeremy Heiner wrote:
> Instead of the one hard-coded (with '#!') in pactest.py. Remove the
> '#!', chmod -x, and comment to discourage well-intentioned reversion.
> Update README. Remove useless '#!' from non-main .py files.
> 
> Signed-off-by: Jeremy Heiner <ScalaProtractor at gmail.com>
> ---

<snip>

> diff --git a/test/pacman/README b/test/pacman/README
> index c7aeb10..f111cd6 100644
> --- a/test/pacman/README
> +++ b/test/pacman/README
> @@ -55,12 +55,12 @@ Usage
>  pactest will run the suite of test files passed as arguments.
>  
>  Example:
> -	./pactest.py tests/*.py
> +	python2.7 pactest.py tests/*.py
>  
>  This example will run all tests from the "tests" directory.
>  
>  Use the "help" option to get the full list of parameters:
> -	./pactest.py --help
> +	python2.7 pactest.py --help
>  
>  The following pieces of software are required to run the pactest suite:
>  
> diff --git a/test/pacman/pactest.py b/test/pacman/pactest.py
> old mode 100755
> new mode 100644
> index e21cde7..46aa913
> --- a/test/pacman/pactest.py
> +++ b/test/pacman/pactest.py
> @@ -1,4 +1,4 @@
> -#! /usr/bin/python2
> +# (no '#!' here because configure picks PYTHON)

What is the point of removing this shebang and changing the mode?  The only
thing that accomplishes is making it impossible to run directly.

>  #
>  #  pactest : run automated testing on the pacman binary
>  #
> diff --git a/test/pacman/pmdb.py b/test/pacman/pmdb.py
> index 53de91e..61be95f 100644
> --- a/test/pacman/pmdb.py
> +++ b/test/pacman/pmdb.py
> @@ -1,4 +1,3 @@
> -#! /usr/bin/python2
>  #

No need to leave these lone '#'.

>  #  Copyright (c) 2006 by Aurelien Foret <orelien at chez.com>
>  #  Copyright (c) 2006-2013 Pacman Development Team <pacman-dev at archlinux.org>