[pacman-dev] [PATCH 2/2] Use the 'configure'd PYTHON to run pactest.

Jeremy Heiner scalaprotractor at gmail.com
Fri Dec 20 00:30:47 EST 2013

On Thu, Dec 19, 2013 at 11:35 PM, Andrew Gregory
<andrew.gregory.8 at gmail.com> wrote:
> On 12/19/13 at 03:31pm, Jeremy Heiner wrote:

>> -#! /usr/bin/python2
>> +# (no '#!' here because configure picks PYTHON)
> What is the point of removing this shebang and changing the mode?  The only
> thing that accomplishes is making it impossible to run directly.

The intent was stated in the commit message as "to discourage
well-intentioned reversion"... I.e. without this change it is more
likely in the future that someone will submit a patch that says
"Makefile.am can be made simpler by removing the $(PYTHON) from
PY_LOG_COMPILER since pactest.py is executable." Besides, I wager you
and me are the only ones who have run pactest directly in the past 6
months. It's just so much more pleasant to let 'make check' run it and
format the output nicely.

>> -#! /usr/bin/python2
>>  #
> No need to leave these lone '#'.

No need to take them out, either.

More information about the pacman-dev mailing list