[pacman-dev] [PATCH v3 3/3] [pactest] Remove conditional checks for fakechroot from test files

[Allan McRae]

On 01/02/13 13:24, Chirantan Ekbote wrote:
> We don't want test files to do any checks for fakechroot since we will
> print a warning if it is not found. 
> 
> Signed-off-by: Chirantan Ekbote <chirantan.ekbote at gmail.com>
> ---

I'm going to accept this because I think the test-suite should either
explicitly state it is skipping a test or enforce the dependencies
before it runs.  Hiding a potential failure is not right.

Allan


>  test/pacman/tests/scriptlet001.py | 4 ----
>  test/pacman/tests/scriptlet002.py | 4 ----
>  2 files changed, 8 deletions(-)
> 
> diff --git a/test/pacman/tests/scriptlet001.py b/test/pacman/tests/scriptlet001.py
> index 6f702eb..a8350b1 100644
> --- a/test/pacman/tests/scriptlet001.py
> +++ b/test/pacman/tests/scriptlet001.py
> @@ -11,7 +11,3 @@
>  self.addrule("PACMAN_RETCODE=0")
>  self.addrule("FILE_EXIST=pre_install")
>  self.addrule("FILE_EXIST=post_install")
> -
> -fakechroot = util.which("fakechroot")
> -if not fakechroot:
> -	self.expectfailure = True
> diff --git a/test/pacman/tests/scriptlet002.py b/test/pacman/tests/scriptlet002.py
> index 907f419..7d58d03 100644
> --- a/test/pacman/tests/scriptlet002.py
> +++ b/test/pacman/tests/scriptlet002.py
> @@ -11,7 +11,3 @@
>  self.addrule("PACMAN_RETCODE=0")
>  self.addrule("FILE_EXIST=pre_remove")
>  self.addrule("FILE_EXIST=post_remove")
> -
> -fakechroot = util.which("fakechroot")
> -if not fakechroot:
> -	self.expectfailure = True
>