[pacman-dev] [PATCH v3 2/3] [pactest] Print a warning if fakechroot is not found

[Allan McRae]

On 01/02/13 13:24, Chirantan Ekbote wrote:
> Fixes FS#33551.
> 
> Signed-off-by: Chirantan Ekbote <chirantan.ekbote at gmail.com>
> ---

Ack.

Although, I think it would be better if the testsuite just aborted
immediately when not run as root and fakeroot and fakechroot are
missing.  At least there is no point running the test-suite at all if
fakeroot is missing.

>  test/pacman/pmtest.py | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/test/pacman/pmtest.py b/test/pacman/pmtest.py
> index 1d198f0..d141567 100644
> --- a/test/pacman/pmtest.py
> +++ b/test/pacman/pmtest.py
> @@ -204,7 +204,9 @@ def run(self, pacman):
>                  cmd.append("fakeroot")
>  
>              fakechroot = util.which("fakechroot")
> -            if fakechroot:
> +            if not fakechroot:
> +                print "WARNING: fakechroot not found!"
> +            else:
>                  cmd.append("fakechroot")
>  
>          if pacman["gdb"]:
>