[pacman-dev] [PATCH 1/3] pacdiff: improve speed, accuracy finding active configs using pacmandb

Allan McRae allan at archlinux.org
Fri Jul 19 22:30:09 EDT 2013


On 20/07/13 12:03, Dave Reisner wrote:
> On Sat, Jul 20, 2013 at 11:12:35AM +1000, Allan McRae wrote:
>> On 19/07/13 09:29, Dave Reisner wrote:
>>>>> +check_pacsave(){
>>>>> +	for f in "${1}" ${1}.[0-9]; do
>>> Strange that you quoted one of these but not the other. You're hitting
>>> the same 10+ pacsave problem here, too.
>>>
>>>   for f in "$1"{,.+([0-9])}
>>>
>>
>> Question:  do we actually care about that?   Getting pacsaves with that
>> many suffixes actually takes quite a bit of effort.
>>
>> Allan
>>
> 
> It doesn't require a whole lot of effort to support -- I see no reason
> to implement the correct solution rather than a 90% solution.
> 

OK:

@Jonathan: the "Search and ..." patch will need adjusted too.



More information about the pacman-dev mailing list