[pacman-dev] [PATCH 1/3] pacdiff: improve speed, accuracy finding active configs using pacmandb

[Jonathan Frazier]

On 07/20/13 at 12:30pm, Allan McRae wrote:
> On 20/07/13 12:03, Dave Reisner wrote:
> > On Sat, Jul 20, 2013 at 11:12:35AM +1000, Allan McRae wrote:
> >> On 19/07/13 09:29, Dave Reisner wrote:
> >>>>> +check_pacsave(){
> >>>>> +	for f in "${1}" ${1}.[0-9]; do
> >>> Strange that you quoted one of these but not the other. You're hitting
> >>> the same 10+ pacsave problem here, too.
> >>>
> >>>   for f in "$1"{,.+([0-9])}
> >>>
> >>
> >> Question:  do we actually care about that?   Getting pacsaves with that
> >> many suffixes actually takes quite a bit of effort.
> >>
> >> Allan
> >>
> > 
> > It doesn't require a whole lot of effort to support -- I see no reason
> > to implement the correct solution rather than a 90% solution.
> > 
> 
> OK:
> 
> @Jonathan: the "Search and ..." patch will need adjusted too.
> 
> 

Sure, I will rebase and send a v2. I have at least three of the 10
patches I sent which need to be improved. I guess I buried the --help
and option rework in a previous thread. So please review those if you
haven't already.

my todo list is:
rename the pacmandb printing function
remove expansion in arithmetic tests (option handling)
fix spelling in pacmandb commit msg.
fix some quoting of parameters
match pacnew.[0-9]* files instead of pacnew.[0-9] in two patches
implement updatedb question and execution.

...also to not spam incomplete emails while learning to use my phone.

Jonathan