[pacman-dev] [PATCH] makepkg: Put script sourcing before var validation

[William Giokas]

On Thu, Jun 20, 2013 at 09:03:57PM +1000, Allan McRae wrote:
> On 20/06/13 19:32, William Giokas wrote:
> > As it is possible to set things like LOGDEST and PKGDEST in a PKGBUILD,
> > we should probably make sure that we can write to said directories
> > before just assuming we can and breaking functions when we can't.
> > 
> > Signed-off-by: William Giokas <1007380 at gmail.com>
> > ---
> > 
> > I don't think this should cause any issues, but packages that expect
> > $srcdir, $pkgdir, etc. to be set when assigning variables will not work
> > as intended anymore, but I have never come across any scrip that does
> > that, so not really too concerned.
> 
> I have actually had to adjust some of my packages to avoid that and have
> had several complaints about it not really working...
> 
> On the other hand...  I have never seen anyone set PKGDEST within a
> PKGBUILD.

Just some quick re-reading of this, and the build scripts are sourced
before setting srcdir and pkgdir without this. I just wasn't thinking.

Thanks,

-- 
William Giokas | KaiSforza | http://kaictl.net/
GnuPG Key: 0x73CD09CF
Fingerprint: F73F 50EF BBE2 9846 8306  E6B8 6902 06D8 73CD 09CF
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://mailman.archlinux.org/pipermail/pacman-dev/attachments/20130620/582f0e1d/attachment.asc>