[pacman-dev] [PATCH v2 3/6] pacsearch: removed redundant sorting

Allan McRae allan at archlinux.org
Sat Feb 8 20:17:06 EST 2014

On 06/02/14 01:16, Pierre Neidhardt wrote:
> On 14-02-05 09:18:48, Andrew Gregory wrote:
>> On 02/04/14 at 12:16am, Pierre Neidhardt wrote:
>>> Package are processed in the same order as pacman output, so there is no real
>>> need to sort, we can print directly. This makes the code simpler and faster.
>>> The only difference is that local packages will always be printed at the
>>> end. Previously, they were printed before multilib for instance.
>>> Signed-off-by: Pierre Neidhardt <ambrevar at gmail.com>
>>> ---
>>>  contrib/pacsearch.in | 46 ++++++++++++++++------------------------------
>>>  1 file changed, 16 insertions(+), 30 deletions(-)
>> This adds an 8 second delay between sync and local results for me on
>> a cold run.  It's not a deal-breaker for me, but I'd prefer to remove
>> the sort by just storing the results in a list.
> How is the overall runtime?
> Your alternative sounds OK to me, but why is it so important to have everything
> printed in one run?

It is bad to have software freeze in the middle of output.  The user has
no indication what happened.


More information about the pacman-dev mailing list