[pacman-dev] [PATCH v2 2/6] pacsearch: indexing by 'name version' instead of 'name'

Allan McRae allan at archlinux.org
Sat Feb 8 20:22:03 EST 2014


On 07/02/14 12:07, Andrew Gregory wrote:
> On 02/05/14 at 04:15pm, Pierre Neidhardt wrote:
>> On 14-02-05 09:15:28, Andrew Gregory wrote:
>>> On 02/04/14 at 12:16am, Pierre Neidhardt wrote:
>>>> Signed-off-by: Pierre Neidhardt <ambrevar at gmail.com>
>>>> ---
>>>>  contrib/pacsearch.in | 6 +++---
>>>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> What is the gain here?  The pacman output already includes the local
>>> version in the sync results if it's different from the sync version.
>>
>> Not sure I understood your comment correctly. In the old pacsearch pkgname
>> and pkgver were stored in the same cell. When I changed that later on, I
>> inadvertently introduced a regression... This fixes it.
> 
> Ah, I see.  That would have been a good detail to include in the
> commit message.
> 

Yes it would be good to have a detailed commit message, as I am still
not sure what exactly the regression is here?

Allan



More information about the pacman-dev mailing list