[pacman-dev] [PATCH v2 2/6] pacsearch: indexing by 'name version' instead of 'name'

[Pierre Neidhardt]

On 14-02-09 11:22:03, Allan McRae wrote:
> On 07/02/14 12:07, Andrew Gregory wrote:
> > On 02/05/14 at 04:15pm, Pierre Neidhardt wrote:
> >> On 14-02-05 09:15:28, Andrew Gregory wrote:
> >>> On 02/04/14 at 12:16am, Pierre Neidhardt wrote:
> >>>> Signed-off-by: Pierre Neidhardt <ambrevar at gmail.com>
> >>>> ---
> >>>>  contrib/pacsearch.in | 6 +++---
> >>>>  1 file changed, 3 insertions(+), 3 deletions(-)
> >>>
> >>> What is the gain here?  The pacman output already includes the local
> >>> version in the sync results if it's different from the sync version.
> >>
> >> Not sure I understood your comment correctly. In the old pacsearch pkgname
> >> and pkgver were stored in the same cell. When I changed that later on, I
> >> inadvertently introduced a regression... This fixes it.
> > 
> > Ah, I see.  That would have been a good detail to include in the
> > commit message.
> > 
> 
> Yes it would be good to have a detailed commit message, as I am still
> not sure what exactly the regression is here?
> 
> Allan

In the old pacsearch, packages were identified uniquely by pkgfields[1], which
contained pkgname+pkgver. My first patch wave stored pkgver in pkgfields[2], and
continued to identify packages with pkgfields[1] only. Because of that
packages with a different version would appear once only.

What I'm doing now is identifying packages with both pkgfields[1] and
pkgfields[2].

-- 
Pierre Neidhardt

When smashing monuments, save the pedstals -- they always come in handy.
		-- Stanislaw J. Lem, "Unkempt Thoughts"