[pacman-dev] [PATCH] Changed copyright to 2006 - 2015 in version info

Florian Pritz bluewind at xinu.at
Tue Jan 20 18:48:41 UTC 2015


On 20.01.2015 19:26, Robin de Rooij wrote:
> From 749dde01efdde4c69491c36c1244a112de54ce52 Mon Sep 17 00:00:00 2001
> From: Robin de Rooij <rderooij685 at famousgoglemailhoster.com>
> Date: Fri, 16 Jan 2015 22:36:00 +0100
> Subject: [PATCH] Changed copyright to 2006 - 2015 in version info

Please use imperative mood in subject lines to stay in line with what
tools like git merge and git revert do (Revert .., Merge ...), to make
the verb shorter (Changed -> Change) and to make it more readable when
being reverted (Revert "Changed .." -> Revert "Change ..").

> The copyright notice still displayed: 2006 - 2014. I changed the version
> method to 2006 - 2015
> 
> Signed-off-by: Robin de Rooij
> <rderooij685<at>famousgooglemailhoster.com> (Everyone knows the name
> of Google's email service, replace famousgoglemailhoster with Google's
> real email service

Your email address is already visible in the list archives so this is
unnecessary. That said I'm very biased towards using good spam filters
and against making life harder for users (which scrambling your email
address is doing for everyone involved) so ymmv.

Apart from that please use git-send-email to send patches in the future
as this is yet another example of other software messing up whitespace
and/or line breaks. In this case it's somewhat easy to fix because the
patch is small.

Also patchwork (patch tracking system) doesn't pick up this patch
(likely because of the formatting issue) so it could get lost.

> ---
>  src/pacman/pacman.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/pacman/pacman.c b/src/pacman/pacman.c
> index 792c994..28df482 100644
> --- a/src/pacman/pacman.c
> +++ b/src/pacman/pacman.c
> @@ -224,7 +224,7 @@ static void version(void)
>  {
>  	printf("\n");
>  	printf(" .--.                  Pacman v%s - libalpm v%s\n",
> PACKAGE_VERSION, alpm_version());
> -	printf("/ _.-' .-.  .-.  .-.   Copyright (C) 2006-2014 Pacman
> Development Team\n");
> +	printf("/ _.-' .-.  .-.  .-.   Copyright (C) 2006-2015 Pacman
> Development Team\n");
>  	printf("\\  '-. '-'  '-'  '-'   Copyright (C) 2002-2006 Judd Vinet\n");
>  	printf(" '--'\n");
>  	printf(_("                       This program may be freely
> redistributed under\n"
> 



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/pacman-dev/attachments/20150120/93db8008/attachment.asc>


More information about the pacman-dev mailing list