[pacman-dev] [PATCH] Changed copyright to 2006 - 2015 in version info

[Robin de Rooij]

Thanks for the feedback. I'm glad that this was a minor edit, otherwise
line formatting would be a big issue. I wasn't aware of the fact that
Thunderbird messed it up.

Your feedback is appreciated. To be honest, I've never helped developing
with projects in this manner (mailing lists, submitting patches instead of
just using GitHub), so I'm sorry for the messed up patch submission.
git-send-email will be used here in the future.

Oh, and sorry for scrambling my email address like that!

Kind regards,

Robin
On Tue, Jan 20, 2015 at 7:48 PM, Florian Pritz <bluewind at xinu.at> wrote:

> On 20.01.2015 19:26, Robin de Rooij wrote:
> > From 749dde01efdde4c69491c36c1244a112de54ce52 Mon Sep 17 00:00:00 2001
> > From: Robin de Rooij <rderooij685 at famousgoglemailhoster.com>
> > Date: Fri, 16 Jan 2015 22:36:00 +0100
> > Subject: [PATCH] Changed copyright to 2006 - 2015 in version info
>
> Please use imperative mood in subject lines to stay in line with what
> tools like git merge and git revert do (Revert .., Merge ...), to make
> the verb shorter (Changed -> Change) and to make it more readable when
> being reverted (Revert "Changed .." -> Revert "Change ..").
>
> > The copyright notice still displayed: 2006 - 2014. I changed the version
> > method to 2006 - 2015
> >
> > Signed-off-by: Robin de Rooij
> > <rderooij685<at>famousgooglemailhoster.com> (Everyone knows the name
> > of Google's email service, replace famousgoglemailhoster with Google's
> > real email service
>
> Your email address is already visible in the list archives so this is
> unnecessary. That said I'm very biased towards using good spam filters
> and against making life harder for users (which scrambling your email
> address is doing for everyone involved) so ymmv.
>
> Apart from that please use git-send-email to send patches in the future
> as this is yet another example of other software messing up whitespace
> and/or line breaks. In this case it's somewhat easy to fix because the
> patch is small.
>
> Also patchwork (patch tracking system) doesn't pick up this patch
> (likely because of the formatting issue) so it could get lost.
>
> > ---
> >  src/pacman/pacman.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/pacman/pacman.c b/src/pacman/pacman.c
> > index 792c994..28df482 100644
> > --- a/src/pacman/pacman.c
> > +++ b/src/pacman/pacman.c
> > @@ -224,7 +224,7 @@ static void version(void)
> >  {
> >       printf("\n");
> >       printf(" .--.                  Pacman v%s - libalpm v%s\n",
> > PACKAGE_VERSION, alpm_version());
> > -     printf("/ _.-' .-.  .-.  .-.   Copyright (C) 2006-2014 Pacman
> > Development Team\n");
> > +     printf("/ _.-' .-.  .-.  .-.   Copyright (C) 2006-2015 Pacman
> > Development Team\n");
> >       printf("\\  '-. '-'  '-'  '-'   Copyright (C) 2002-2006 Judd
> Vinet\n");
> >       printf(" '--'\n");
> >       printf(_("                       This program may be freely
> > redistributed under\n"
> >
>
>
>
>