[pacman-dev] [PATCH 1/3] makepkg: Do not provide $pkgdir to build()

[David Macek]

On 17. 3. 2015 23:41, Allan McRae wrote:
> Some packages genuinely need this do to poor build systems.
> 
> $ for i in */*; do unset build; . $i/PKGBUILD; if declare -f build |
> grep -q pkgdir; then echo $i; fi; done | wc -l
> 64
> 
> OK - most of those are in [community] so probably bad packaging.  But is
> there a reason to remove this?

No other reason than to clean up the code and enforce the packaging guidelines. If you were to discard this patch, then also disard the second one. I assume some recipes use plain `mkdir $pkgdir`, which would be broken by moving creation of $pkgdirbase after build().

-- 
David Macek

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4234 bytes
Desc: S/MIME Cryptographic Signature
URL: <https://lists.archlinux.org/pipermail/pacman-dev/attachments/20150318/9a920b91/attachment.p7s>