[pacman-dev] [PATCH 1/3] makepkg: Do not provide $pkgdir to build()

[Allan McRae]

On 19/03/15 00:08, David Macek wrote:
> On 17. 3. 2015 23:41, Allan McRae wrote:
>> Some packages genuinely need this do to poor build systems.
>>
>> $ for i in */*; do unset build; . $i/PKGBUILD; if declare -f build |
>> grep -q pkgdir; then echo $i; fi; done | wc -l
>> 64
>>
>> OK - most of those are in [community] so probably bad packaging.  But is
>> there a reason to remove this?
> 
> No other reason than to clean up the code and enforce the packaging guidelines. If you were to discard this patch, then also disard the second one. I assume some recipes use plain `mkdir $pkgdir`, which would be broken by moving creation of $pkgdirbase after build().
> 

Most of the packages that still use $pkgdir during build() have bad
build systems that require DESTDIR set during build.  Don't ask why...

The creation $pkgbasedir with a-srwx and setting $pkgdir to something
sensible was a compromise. I think we should keep it for the time being.

A