[pacman-dev] [PATCH] [RFC] makepkg: move build enviroment set-up to function

Allan McRae allan at archlinux.org
Fri Apr 15 13:59:51 UTC 2016

On 02/04/16 22:50, Allan McRae wrote:
> This is the first set require to split the preparation of the build environment
> into libmakepkg, which will allow dropping in extensions (e.g. to allow PGO).
> After this patch, disabling buildflags or makeflags and enabling debug
> CFLAGS will only effect the build() and check() functions.  These are no longer
> exported for the prepare() and package() function.  This should have zero
> impact for the prepare() and package() functions of a properly written
> PKGBUILD, as no building/linking is done there...
> Signed-off-by: Allan McRae <allan at archlinux.org>
> ---
> Can anyone think of a case where a well written PKGBUILD will be affected by
> this change to handling '!buildflags', '!makeflags' and 'debug'?

To answer my own question...  I can.   Shitty makefiles mean
'!makeflags' may be important for "make install" during package().  So
prepare_buildenv will need run before packaging


More information about the pacman-dev mailing list