[pacman-dev] [PATCH 1/3] Make alpm_graph state signedness explicit
Allan McRae
allan at archlinux.org
Mon Jan 4 03:59:08 UTC 2016
On 31/12/15 23:19, Rikard Falkeborn wrote:
> The signedness of char is implementation defined. Since the
> alpm_graph state is clearly meant to be signed, make the
> signedness explicit.
>
> This fixes bugs on systems where char is unsigned, in comparissons
> of the following type:
>
> if(v.state == -1)
>
> which, if state is unsigned, will never be true due to integer
> promotion rules.
>
> Fixes failing test/pacman/tests/sync012.py when compiling with -funsigned-char.
>
> Fixes two warnings [-Wtype-limits] for comparissons with -1 when compiling
> with -funsigned-char.
>
Pulled.
More information about the pacman-dev
mailing list