[pacman-dev] [PATCH 2/3] pacsort, introduce define for escape_char error code

Allan McRae allan at archlinux.org
Mon Jan 4 04:08:00 UTC 2016

On 31/12/15 23:19, Rikard Falkeborn wrote:
> The signedness of char is implementation defined. On systems where
> char is unsigned, comparing a variable of type char with -1 is never
> true, due to integer promotion rules. To avoid this, introduce a
> define for invalid field separators where -1 is cast to char. This will
> ensure that the return value check works for both unsigned and signed char.
> Fixes one warning [-Wtype-limits] for comparissons with -1 when compiling
> with -funsigned-char.
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn at gmail.com>


More information about the pacman-dev mailing list