[pacman-dev] [Patch] Disable colors and progress bars if TERM=dumb

[Ivy Foster]

On 26 Mar 2016, at  1:58 pm +1000, Allan McRae wrote:
> On 25/03/16 14:13, Ivy Foster wrote:
> > I recently noticed that if colors and progress bars are enabled, pacman
> > will faithfully attempt to print them even to dumb terminals that cannot
> > handle them. This patch fixes that.

> I don't think we can detect every terminal that does not support colours
> properly without using has_colors() from ncurses. I really don't want to
> start a hardcoded list...

Oh, definitely. I was under the impression that if a term couldn't handle
escape sequences gracefully (whether or not it actually uses them for
formatting being a different question), it was expected to report as the
catch-all "dumb"; and if it could then it could report its capabilities
through ncurses/terminfo. If that's not the case, then...my bad!

> Is there a case where people switch between terminals with differing
> colour support on such a regular basis that NoColor in pacman.conf is
> not enough?  Or --color never?

That's a good point.

Ah, well. Cheers, and thanks for considering it!

iff