[pacman-dev] Downloader options - Was: Add configuration options for libcurl's "low speed" timeout

[Allan McRae]

On 30/08/16 22:48, Christian Hesse wrote:
> Dave Reisner <d at falconindy.com> on Tue, 2016/08/30 08:46:
>> On Tue, Aug 30, 2016 at 02:12:23PM +0200, Christian Hesse wrote:
>>> From: Christian Hesse <mail at eworm.de>
>>>
>>> Add LowSpeedLimit and LowSpeedTime configuration options to correspond
>>> to libcurl's CURLOPT_LOW_SPEED_LIMIT and CURLOPT_LOW_SPEED_TIME options.
>>> This allows, e.g., transfers behind corporate virus-scanning firewalls
>>> to survive the delays. Increasing the timeout may not be desirable in
>>> all situations; similarly, disabling the check prevents detection of
>>> disappearing networks.  
>>
>> FWIW, I'm strongly opposed to having a 1:1 mapping between pacman
>> options and curl config options. Please look at the bigger picture --
>> it's dead connection detection. We might reimplement that in the future
>> in some other way (e.g. via the progress callback or by some other
>> transfer library entirely).
>>
>> To that end, I think it would be reasonable to add a boolean toggle for
>> the dead connection detection (default on). The patch in its current
>> state makes me rather itchy from an API perspective.
> 
> That is what my stupid-proxy patch does...
> Now it is up to Allan to decide. ;)

Crap...  Why do I need to make decisions?

OK - lets think on the go here...  The two options we "want" to support
based on submitted patches are:
1) Disabling the low speed timeout
2) Setting maximum download speed

In the future, we might also add a parallel download option.

I'm guessing these want both global config values and command line
options.  Anyone want to suggest what these could be.  I'll choose the
colour of the bikeshed.

Allan