[pacman-dev] [PATCH] Allow query of file owners to work with non-existing files

Andrew Gregory andrew.gregory.8 at gmail.com
Fri Jan 5 00:38:50 UTC 2018


On 09/14/17 at 04:20pm, Allan McRae wrote:
> On 14/09/17 16:16, Vladimir Panteleev wrote:
> > On 2017-09-14 04:21, Allan McRae wrote:
> >> This test passes before and after your patch...   And the etc/config
> >> file is installed into the test root, so you are not testing a -Qo on a
> >> missing file.
> > 
> > You're right, thanks.
> > 
> > What would be a good way to test this? I don't think there's a way to do
> > it with the existing pmtest/pmpkg methods. I figured adding a "deleted"
> > flag to getfileinfo would be one way, however filesystem entries are
> > processed before package entries, and though I did get things to work
> > with `sp.files = ["etc/foo", "etc/config", "etc/config-"]` (i.e. create
> > the file and then delete it during the simulated package installation),
> > that's probably too clever.
> > 
> > Should there be a pmtest.filesystem_delete to complement pmtest.filesystem?
> > 
> 
> @Andrew - can you help out here?  You know the internals of the testing
> system better than I do...

Sorry, this slipped under my radar.  Unfortuntately, I don't think
there's any way to get our test suite to do this without extending it.
Frankly, though, this is pretty non-essential, I would not be bothered
leaving this out of our test suite.

Since I missed this for so long, we now have a second patch for
querying missing files: https://patchwork.archlinux.org/patch/290/

apg


More information about the pacman-dev mailing list