[pacman-dev] [PATCH 1/2] libmakepkg/integrity: fix regression that broke invalid file sigs

Allan McRae allan at archlinux.org
Sat Jan 6 02:38:39 UTC 2018

On 22/11/17 14:34, Eli Schwartz wrote:
> In 42e7020281d3ae260e1e9693495f527b7f476625 creating the gpg statusfile
> for a source file was split into a separate function, which used the
> return code to indicate unsigned files and proto-specific errors.
> However, the fallback return code was set by the final gpg invocation,
> which would be 1 if the signature was somehow broken (for example, the
> key was not available in the gpg keyring). As a result makepkg thought
> that file did not have a signature and skipped over it rather than
> erroring out.
> Fix this by explicitly setting the return code for all
> verify_*_signature() functions.


More information about the pacman-dev mailing list