[pacman-dev] [PATCH] do not rely on name hashes for matching

Allan McRae allan at archlinux.org
Sat Jan 6 03:36:13 UTC 2018


On 21/12/17 14:22, Andrew Gregory wrote:
> 6cfc4757b98e813428d261dbc185e20618ca83a6 was overzealous in attempting
> to optimize away a call to strcmp based on a comparison of hashes.  The
> call can be skipped if the hashes are different, but different strings
> could have the same hash.
> 
> Signed-off-by: Andrew Gregory <andrew.gregory.8 at gmail.com>
> ---

Good catch!  I'm interest if you saw an issue in the wild?

A


More information about the pacman-dev mailing list