[pacman-dev] [PATCH] do not rely on name hashes for matching

Andrew Gregory andrew.gregory.8 at gmail.com
Sat Jan 6 05:41:41 UTC 2018


On 01/06/18 at 01:36pm, Allan McRae wrote:
> On 21/12/17 14:22, Andrew Gregory wrote:
> > 6cfc4757b98e813428d261dbc185e20618ca83a6 was overzealous in attempting
> > to optimize away a call to strcmp based on a comparison of hashes.  The
> > call can be skipped if the hashes are different, but different strings
> > could have the same hash.
> > 
> > Signed-off-by: Andrew Gregory <andrew.gregory.8 at gmail.com>
> > ---
> 
> Good catch!  I'm interest if you saw an issue in the wild?
> 
> A

Nope, just noticed it as I was looking through the deps code.

apg


More information about the pacman-dev mailing list