[pacman-dev] [PATCH] makepkg: use localized date strings

Chih-Hsuan Yen yan12125 at gmail.com
Wed Mar 7 04:03:50 UTC 2018


Hello,

Does this patch requires more work? Or I was doing something wrong in
submitting patches? I'll be grateful for any further feedback.

Best Regards,

Chih-Hsuan Yen

2018-02-11 1:27 GMT+08:00 Chih-Hsuan Yen <yan12125 at gmail.com>:
> From: Yen Chi Hsuan <yan12125 at gmail.com>
>
> Before this change, LC_TIME=zh_TW.UTF-8 makepkg has the following line:
>
> ==> Making package: foobar 1-1 (日  2月 11 01:13:42 CST 2018)
>
> With this patch, this line becomes:
>
> ==> Making package: foobar 1-1 (西元2018年02月11日 (週日) 01時13分57秒)
>
> The latter is more natural for a Chinese native speaker.
>
> Signed-off-by: Chih-Hsuan Yen <yan12125 at gmail.com>
> ---
>  scripts/makepkg.sh.in | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
> index 63b6c3e1..5e3af337 100644
> --- a/scripts/makepkg.sh.in
> +++ b/scripts/makepkg.sh.in
> @@ -1569,7 +1569,7 @@ if (( INFAKEROOT )); then
>         exit $E_OK
>  fi
>
> -msg "$(gettext "Making package: %s")" "$pkgbase $basever ($(date))"
> +msg "$(gettext "Making package: %s")" "$pkgbase $basever ($(date +%c))"
>
>  # if we are creating a source-only package, go no further
>  if (( SOURCEONLY )); then
> @@ -1597,7 +1597,7 @@ if (( SOURCEONLY )); then
>         msg "$(gettext "Signing package...")"
>         create_signature "$SRCPKGDEST/${pkgbase}-${fullver}${SRCEXT}"
>
> -       msg "$(gettext "Source package created: %s")" "$pkgbase ($(date))"
> +       msg "$(gettext "Source package created: %s")" "$pkgbase ($(date +%c))"
>         exit $E_OK
>  fi
>
> @@ -1703,7 +1703,7 @@ if (( NOARCHIVE )); then
>         exit $E_OK
>  fi
>
> -msg "$(gettext "Finished making: %s")" "$pkgbase $basever ($(date))"
> +msg "$(gettext "Finished making: %s")" "$pkgbase $basever ($(date +%c))"
>
>  install_package && exit $E_OK || exit $E_INSTALL_FAILED
>
> --
> 2.16.1
>


More information about the pacman-dev mailing list