[pacman-dev] [PATCH] repo-add: should have option to prevent downgrading

[Eli Schwartz]

On 4/28/19 2:21 AM, ekardnam wrote:
> Hello,
> 
> following this report #FS17752 (link at [0]) I made a patch to repo-add
> 
> From 972a5e88df392042d60e5aea1e52e8c5dd113a69 Mon Sep 17 00:00:00 2001
> From: ekardnam <lucabertozzi.pub at gmail.com>
> Date: Tue, 26 Mar 2019 21:28:39 +0000
> Subject: [PATCH] Added --dont-downgrade flag to repo-add as stated in issue
>  #17752
Thanks for the patch. This seems to be a mailing list resubmission of
the patch that was originally attached to the bugtracker at
https://bugs.archlinux.org/task/17752#comment178160

But it was submitted with Thunderbird, which unfortunately does not
handle git patches very well... actually, most email clients break
patches. Could you resubmit it using `git send-email`? It's very
difficult to find any alternative method which is reliable...

It is currently a Mime-encoded base64 blob with accompanying PGP
signature, which git am does not understand, although patchwork did
manage to extract a patch from it... but even so, the email does not
apply due to tabs being converted to spaces.

Note: All this is mostly described in
https://www.archlinux.org/pacman/submitting-patches.html

Note2: If you want to add additional notes as described in the
Submitting Patches documentation, then you will find the --annotate
option to git send-email, to be helpful.

...

While I am at it, I would like to suggest slightly tweaking your commit
message. You don't need to mention "as stated in issue #17752" in the
subject. OTOH, you could/should add "Fixes #17752" as a second paragraph.

The patch changes look good to my cursory inspection, so once that is
done, we are back to waiting for Allan to do another roundup and pull
the latest patches into his queue. :)

-- 
Eli Schwartz
Bug Wrangler and Trusted User

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 1601 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/pacman-dev/attachments/20190428/ae5fa8ab/attachment.sig>