[pacman-dev] [PATCH] repo-add: should have option to prevent downgrading

[ekardnam]

Thanks for the feedback,

I'll post using git-send-mail later has I'm having some troubles with some perl ssl modules it requires. (I even had read that page but completely forgot about that, sorry about that)

Yeah I resubmitted the patch because I thought it went lost, didn't mean to rush you. I thought you may have preffered having the patch on the mailing list
rather than in the bugtracker.

Thanks for your suggestions, I'll take them into practice in the next patch resubmission using git -send-mail

On 28/04/19 07:25, Eli Schwartz wrote:

>
> While I am at it, I would like to suggest slightly tweaking your commit
> message. You don't need to mention "as stated in issue #17752" in the
> subject. OTOH, you could/should add "Fixes #17752" as a second paragraph.
>
> The patch changes look good to my cursory inspection, so once that is
> done, we are back to waiting for Allan to do another roundup and pull
> the latest patches into his queue. :)
>
I was suggested by Allan on the bug tracker to use --no-downgrade, then at the time I was writing it it became --dont-downgrade in my head (lol)
My initial idea was --keep-latest, but in the end I think --no-downgrade would be the better option (rather than --dont-downgrade).But it can for sure be discussed

> Negative options always read a bit oddly.
> How about the positive --keep-new?
> That's the sense used in the warning message.
>
> --
> Cheers, Ralph.
> --dont-downgrade is way more clear than --keep-new in my opinion.
>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/pacman-dev/attachments/20190428/f34589f9/attachment.sig>