[pacman-dev] [RFC PATCH] makepkg: add support for SAMUFLAGS, comparable to MAKEFLAGS

[Allan McRae]

On 4/7/19 7:57 am, Eli Schwartz wrote:
> SAMUFLAGS is recently added to the samurai build tool, an implementation
> of the ninja build format (which is a competitor to Makefiles).
> Currently, samurai implements support for -v (verbose) and -j
> (configuring the number of parallel jobs) and rejects all other
> SAMUFLAGS.
> 
> Adding SAMUFLAGS support to makepkg will allow users to configure how
> many jobs to use when building packages, which is an important
> consideration as the ninja build format is becoming fairly popular these
> days; meson uses it exclusively, cmake can optionally output it, and it
> can often speed up the time a build takes.
> 
> Signed-off-by: Eli Schwartz <eschwartz at archlinux.org>
> ---
> 
> Support for SAMUFLAGS is only in git master. See
> https://github.com/michaelforney/samurai/pull/21 for discussion about
> its implementation.
> 
> Submitting patch now for bikeshed purposes, but it "should" be safe to
> pull in as there will hopefully be a new samurai release in a week or
> two, and I expect this patch will take longer to review anyway, and even
> longer for pacman 5.2 :p
> 
> Note: this overlaps with the RUSTFLAGS patch, and therefore depends on
> it. In the unlikely event that this patch gets accepted *first*, I can
> rebase it...
> 

I'm saying no to this.  It is not part of the ninja spec (and not
supported by ninja itself), and we could end up with a lot of
fragmentation before this is agreed upon between the two (?)
implementations.

Allan