[pacman-dev] [PATCH] makepkg: add rust support for *FLAGS and debug-prefix-map

[Allan McRae]

On 4/7/19 7:40 am, Eli Schwartz wrote:
> The rust language supports $RUSTFLAGS to be used automatically in all
> rustc invocations. Allow setting this in makepkg.conf (e.g. for
> optimization or debuginfo support), and teach debug+strip to pass the
> rustc command line argument necessary to rewrite source file paths in
> the debugging symbols.
> 

I'm happy to include this.

But it brings me back to the concern of an ever expanding makepkg.conf
(no longer just compression variables!).

What about adding a system like:
/etc/makepkg.conf
/etc/makepkg.conf.d/rust

Still need to plug the logic to use them in, but should be possible with
libmakepkg...

> diff --git a/scripts/libmakepkg/buildenv/buildflags.sh.in b/scripts/libmakepkg/buildenv/buildflags.sh.in
> index daccc9cc..871d0d69 100644
> --- a/scripts/libmakepkg/buildenv/buildflags.sh.in
> +++ b/scripts/libmakepkg/buildenv/buildflags.sh.in
> @@ -30,6 +30,6 @@ buildenv_functions+=('buildenv_buildflags')
>  
>  buildenv_buildflags() {
>  	if check_option "buildflags" "n"; then
> -		unset CPPFLAGS CFLAGS DEBUG_CFLAGS CXXFLAGS DEBUG_CXXFLAGS LDFLAGS
> +		unset CPPFLAGS CFLAGS DEBUG_CFLAGS CXXFLAGS DEBUG_CXXFLAGS LDFLAGS RUSTFLAGS

DEBUG_RUSTFLAGS

>  	fi
>  }