[pacman-dev] [PATCH 3/5] sync: lookup missing keys in the WKD using the packager email

Eli Schwartz eschwartz at archlinux.org
Mon Aug 5 16:07:04 UTC 2019

On 8/5/19 11:37 AM, Jonas Witschel wrote:
> Hi,
> thank you for the review!

New suggestion:

You can do inline comments for a patch using git send-email --annotate,
and insert descriptions like:

v2: changed foo to bar

After the "---" which ends the commit message and before the "diff
--git". There are already some comments there, e.g.

 scripts/libmakepkg/lint_config/variable.sh.in | 5 +++++
 1 file changed, 5 insertions(+)

Common practice in many circles is to add commentary or changelogs on
the patch, in between the "---" and this summary


Describing what changed between v1 and v2 of a patch, in the patch
email, makes it easier to follow the evolution of a patch, vs.
consulting a followup email and trying to map each reply to the affected
changeset. Could help. :)

Eli Schwartz
Bug Wrangler and Trusted User

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 1601 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/pacman-dev/attachments/20190805/66d9b708/attachment.sig>

More information about the pacman-dev mailing list