[pacman-dev] [PATCH] autotools: emit error message when autoconf-archive is missing

Eli Schwartz eschwartz at archlinux.org
Sun Jan 5 21:04:21 UTC 2020


Forbid the AX_COMPARE_VERSION macro from being found in the output
configure script. If autoconf-archive is not installed when autoreconf
is run, the following error message is emitted:

configure.ac:231: error: possibly undefined macro: AX_COMPARE_VERSION
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
autoreconf: /usr/bin/autoconf failed with exit status: 1

Signed-off-by: Eli Schwartz <eschwartz at archlinux.org>
---

Actually, I think we can catch this error in a more visible way! At
least now people will be able to tell that the autoreconf was borked and
"it's missing something", and "possibly undefined macro" has better
googleability than:

(dash)
./configure: Syntax error: word unexpected (expecting ")")

 configure.ac | 1 +
 1 file changed, 1 insertion(+)

diff --git a/configure.ac b/configure.ac
index e59f82e9..9db39232 100644
--- a/configure.ac
+++ b/configure.ac
@@ -228,6 +228,7 @@ PKG_CHECK_VAR(bashcompdir, [bash-completion], [completionsdir], ,
 PKG_CHECK_MODULES(LIBARCHIVE, [libarchive >= 3.0.0], ,
 	AC_MSG_ERROR([*** libarchive >= 3.0.0 is needed to compile pacman!]))
 
+m4_pattern_forbid([^AX_COMPARE_VERSION$])
 # Check file for seccomp
 if test "x$with_file_seccomp" = "xauto"; then
 	file_version="$(file --version| sed -n 's/^file-\(.*\)/\1/p')"
-- 
2.24.1


More information about the pacman-dev mailing list