[pacman-dev] Fix srcinfo sometimes printing double newline at the end

[Allan McRae]

On 26/6/20 9:27 am, Denton Liu wrote:
> Hi Marti,
> 
> On Fri, Jun 26, 2020 at 01:09:54AM +0200, Martin Rys wrote:
>> Hi,
>> this is a bit of an OCD thing, but `makepkg --printsrcinfo` usually
>> generates a file with two newlines at the end.
> 
> I agree with you, this bugs me a lot too.
> 
> [...]
> 
>> Which seems to always print out a newline, so I believe the
>> srcinfo_close_section function is not needed there and simply
>> removing it and the two lines that call it would solve this issue, as
>> per the patchfile in the attachment.
> 
> I proposed a similar patch recently[0] but it was rejected as the
> newline separators are apparently part of the spec so they should be
> retained[1]. I sent out another patch after that only removes the final
> newline but it wasn't reviewed so I thought that the pacman devs thought
> it was a non-issue. Since you seem to agree with me, though, I'll resend
> that patch and hopefully it'll be reviewed this time around.
> 

Please do not resend patches.  We have a patch tracking system, which
means patches are never lost.

I have given this patch a very low priority. That means with limited
time available to me, I will likely review other patches first.  But it
will get considered at some stage.

Allan