On Wed, May 06, 2020 at 11:19:04PM +0200, Frederik Schwan via aur-general wrote:

Hi everyone, my name is Frederik aka freswa and I'm applying to become a Trusted User with svenstaro's and grazzolini's sponsorship.

Hi Freswa!

I started using Linux around 2004 with some live images of Ubuntu. In 2010, Debian became my main OS. Only a year later I switched to Arch after I screwed up Debian/sid while hunting for the latest kernel. I'm interested in DevOps topics, mail server, C, Rust, Go and newer JVM languages such as Kotlin.

Thanks to svenstaro I've been a bug wrangler since February. You mostly hear from me when I assign bugs to the wrong people from time to time :P

OS contributions: - working on the dovecot-xaps code, providing native Mail.app Apple Push for iOS devices - maintaining and writing PKGBUILDs for the AUR - bug reporting and fixing for several projects

My AUR packages got reviewed recently by eschwartz, svenstaro and alad - thanks :)

If I become a TU, I'd like to focus on the bug tracker until we have a better solution. I'd also like to help out bug fixing when maintainers are busy, away or on vacation.

Packages which I would like to move to [Community], some of which are not mine:

I'll do a review of your PKGBUILDS for these, but I'm curious to know if you also had any orphans on community that you were considering/interested on adopting[1]. To add to this, any other packages on community that you'd be interested in co-maintaining? :) Cheers! -Santiago [1] https://www.archlinux.org/packages/?repo=Community&maintainer=orphan

On 5/6/20 11:19 PM, Frederik Schwan via aur-general wrote:

Hi everyone, my name is Frederik aka freswa and I'm applying to become a Trusted User with svenstaro's and grazzolini's sponsorship.

I started using Linux around 2004 with some live images of Ubuntu. In 2010, Debian became my main OS. Only a year later I switched to Arch after I screwed up Debian/sid while hunting for the latest kernel. I'm interested in DevOps topics, mail server, C, Rust, Go and newer JVM languages such as Kotlin.

Thanks to svenstaro I've been a bug wrangler since February. You mostly hear from me when I assign bugs to the wrong people from time to time :P

That rings a bell, thanks for helping out with our bugtracker - even if that means some things get accidentally assigned wrong :p

OS contributions: - working on the dovecot-xaps code, providing native Mail.app Apple Push for iOS devices - maintaining and writing PKGBUILDs for the AUR - bug reporting and fixing for several projects

My AUR packages got reviewed recently by eschwartz, svenstaro and alad - thanks :)

Hey, i just submitted all AUR PKGBUILDs that you are a (co-)maintainer for to my PKGBUILD checker and there are a couple of things you should review most importantly: - all references to $srcdir & co should be quoted as those might contain spaces, leading to undesireable word-splitting - foo should never conflict/provide foo-git, those relations should work the other way around - http URLs should be upgraded to https when the remote supports it At the bottom of this mail you'll find the raw checker output, please review and adjust as needed :)

If I become a TU, I'd like to focus on the bug tracker until we have a better solution. I'd also like to help out bug fixing when maintainers are busy, away or on vacation.

Packages which I would like to move to [Community], some of which are not mine: docker-credential-pass i3status-rust intel-undervolt ispin mysqltuner pdfposter pinentry-rofi protobuf-go sha3sum spin talosctl thermald unifi woeusb

I'm aware though that some of these packages do not meet the criteria of 10 votes yet. I'll reevaluate whether they meet this criteria from time to time. I'd also like to go on helping Eli with maintenance of zfs-dkms and zfs-utils in the AUR.

AUR package maintenance is orthogonal to TU duties ^^ - you should talk to Eli directly about this

In case JetBrains is okay with us packaging their IDE's, I'd also maintain them. But so far all requests I found resulted in a negative response from JB.

As far as i know, JetBrains is quite adamant on people using their "Toolbox" for managing JetBrains software, good luck though.

I am looking forward to working with you! Frederik

Good luck with the rest of your application! Checker output mentioned above: adobe-icc: Warning: Potentially unintentional HTTP URL on line 10 Offending line: url='http://www.adobe.com/support/downloads/iccprofiles/iccprofiles_mac.html' Warning: Potentially unintentional HTTP URL on line 13 Offending line: source=('http://download.adobe.com/pub/adobe/iccprofiles/mac/AdobeICCProfilesCS4Mac_e...' brother-hl4150cdn: Warning: Potentially unintentional HTTP URL on line 9 Offending line: url='http://support.brother.com/g/b/downloadlist.aspx?c=de&lang=de&prod=hl4150cdn_all&os=127&flang=English' Warning: Potentially unintentional HTTP URL on line 17 Offending line: "http://download.brother.com/welcome/dlf005939/hl4150cdnlpr-${pkgver}-${pkgrel}.i386.rpm" Warning: Potentially unintentional HTTP URL on line 18 Offending line: "http://download.brother.com/welcome/dlf005941/hl4150cdncupswrapper-${pkgver}-${pkgrel}.i386.rpm") datagrip: Warning: Potentially unintentional HTTP URL on line 9 Offending line: url='http://www.jetbrains.com/datagrip/' dovecot-xaps-daemon: Style: 'conflicts' on line 10 should not contain other variant(s) of 'dovecot-xaps-daemon' Offending line: conflicts=('dovecot-xaps-daemon-git') dovecot-xaps-plugin: Style: 'conflicts' on line 11 should not contain other variant(s) of 'dovecot-xaps-plugin' Offending line: conflicts=('dovecot-xaps-plugin-git') exfat-utils-nofuse: Error: Potentially unquoted variable may contain spaces and should be quoted on line 22 Offending line: patch -p0 < ${srcdir}/nofuse.patch flexbox-udev: Error: Potentially unquoted variable may contain spaces and should be quoted on line 14 Offending line: install -Dm644 ${srcdir}/99-tprogrammer.rules ${pkgdir}/usr/lib/udev/rules.d/99-tprogrammer.rules gtkhotkey: Warning: Potentially unintentional HTTP URL on line 17 Offending line: source=("http://launchpad.net/$pkgname/0.2/$pkgver/+download/$pkgname-$pkgver.tar.gz" hipchat: Warning: Potentially unintentional HTTP URL on line 6 Offending line: # Contributor: Tom Vincent http://tlvince.com/contact imapsync: Warning: Potentially unintentional HTTP URL on line 8 Offending line: url='http://www.linux-france.org/prj/' ispin: Warning: Potentially unintentional HTTP URL on line 9 Offending line: url='http://spinroot.com/' jetbrains-toolbox: Warning: Potentially unintentional HTTP URL on line 8 Offending line: url='http://www.jetbrains.com/toolbox/' jtool-bin: Warning: Potentially unintentional HTTP URL on line 8 Offending line: url='http://www.newosxbook.com/tools/jtool.html' Warning: Potentially unintentional HTTP URL on line 10 Offending line: source=('http://www.newosxbook.com/tools/jtool.tar') libpurple-lurch: Style: 'provides' on line 12 should not contain other variant(s) of 'libpurple-lurch' Offending line: provides=('libpurple-lurch-git') makemkv-cli: Warning: Potentially unintentional HTTP URL on line 9 Offending line: url='http://www.makemkv.com' minetime-bin: Style: 'pkgdesc' on line 5 should not end on punctuation Offending line: pkgdesc='MineTime is a modern, intuitive and smart calendar application.' namebench: Warning: Potentially unintentional HTTP URL on line 10 Offending line: url='http://code.google.com/p/namebench/' nameinator: Error: Potentially unquoted variable may contain spaces and should be quoted on line 32 Offending line: install -Dm755 ${srcdir}/gopath/bin/${pkgname} "${pkgdir}"/usr/bin/${pkgname} onivim2: Style: 'conflicts' on line 14 should not contain other variant(s) of 'onivim2' Offending line: conflicts=('onivim2-git') or-tools-java: Style: 'pkgdesc' on line 5 should not end on punctuation Offending line: pkgdesc='Google`s Operations Research tools. With Java bindings.' Error: Potentially unquoted variable may contain spaces and should be quoted on line 46 Offending line: for i in ${pkgdir}/usr/lib/${pkgname}/*.so.*; do ln -rs ${i} ${i%so.*}so; done parcimonie-sh-git: Style: 'validpgpkeys' on line 14 is empty and should be removed Offending line: validpgpkeys=( perl-http-dav: Warning: Potentially unintentional HTTP URL on line 10 Offending line: url='http://search.cpan.org/dist/HTTP-DAV' Warning: Potentially unintentional HTTP URL on line 11 Offending line: source=("http://search.cpan.org/CPAN/authors/id/C/CO/COSIMO/HTTP-DAV-${pkgver}.tar.gz") perl-json-webtoken: Warning: Potentially unintentional HTTP URL on line 8 Offending line: url="http://search.cpan.org/~xaicron/JSON-WebToken/" Warning: Potentially unintentional HTTP URL on line 13 Offending line: source=("http://search.cpan.org/CPAN/authors/id/X/XA/XAICRON/JSON-WebToken-${pkgver}.tar.gz") perl-ntlm: Warning: Potentially unintentional HTTP URL on line 9 Offending line: url='http://search.cpan.org/~nbebout/NTLM/' Warning: Potentially unintentional HTTP URL on line 12 Offending line: source=("http://search.cpan.org/CPAN/authors/id/N/NB/NBEBOUT/NTLM-${pkgver}.tar.gz") pxz: Warning: Potentially unintentional HTTP URL on line 11 Offending line: url='http://jnovy.fedorapeople.org/pxz/' sendip: Style: 'pkgdesc' on line 7 should not end on punctuation Offending line: pkgdesc='A commandline tool to allow sending arbitrary IP packets.' thunderbird-nightly: Warning: Potentially unintentional HTTP URL on line 12 Offending line: url="http://www.mozilla.org/thunderbird" tomighty: Warning: Potentially unintentional HTTP URL on line 9 Offending line: url='http://www.tomighty.org/' ttf-freebanglafont: Warning: Potentially unintentional HTTP URL on line 10 Offending line: url='http://www.ekushey.org/' ttf-ubraille: Warning: Potentially unintentional HTTP URL on line 10 Offending line: url='http://yudit.org/download/fonts/UBraille/' Warning: Potentially unintentional HTTP URL on line 14 Offending line: source=('http://yudit.org/download/fonts/UBraille/UBraille.ttf') webstorm: Style: 'pkgdesc' on line 8 should not end on punctuation Offending line: pkgdesc='JavaScript IDE and HTML editor.' xfce-polkit: Style: 'conflicts' on line 11 should not contain other variant(s) of 'xfce-polkit' Offending line: conflicts=('xfce-polkit-git' 'polkit-gnome') youtrack: Warning: Potentially unintentional HTTP URL on line 8 Offending line: url='http://www.jetbrains.com/youtrack/' -- Rob (coderobe) O< ascii ribbon campaign - stop html mail - www.asciiribbon.org

Em maio 6, 2020 18:19 Frederik Schwan via aur-general escreveu:

Hi everyone, my name is Frederik aka freswa and I'm applying to become a Trusted User with svenstaro's and grazzolini's sponsorship.

I started using Linux around 2004 with some live images of Ubuntu. In 2010, Debian became my main OS. Only a year later I switched to Arch after I screwed up Debian/sid while hunting for the latest kernel. I'm interested in DevOps topics, mail server, C, Rust, Go and newer JVM languages such as Kotlin.

Thanks to svenstaro I've been a bug wrangler since February. You mostly hear from me when I assign bugs to the wrong people from time to time :P

OS contributions: - working on the dovecot-xaps code, providing native Mail.app Apple Push for iOS devices - maintaining and writing PKGBUILDs for the AUR - bug reporting and fixing for several projects

My AUR packages got reviewed recently by eschwartz, svenstaro and alad - thanks :)

If I become a TU, I'd like to focus on the bug tracker until we have a better solution. I'd also like to help out bug fixing when maintainers are busy, away or on vacation.

Packages which I would like to move to [Community], some of which are not mine: docker-credential-pass i3status-rust intel-undervolt ispin mysqltuner pdfposter pinentry-rofi protobuf-go sha3sum spin talosctl thermald unifi woeusb

I'm aware though that some of these packages do not meet the criteria of 10 votes yet. I'll reevaluate whether they meet this criteria from time to time. I'd also like to go on helping Eli with maintenance of zfs-dkms and zfs-utils in the AUR.

In case JetBrains is okay with us packaging their IDE's, I'd also maintain them. But so far all requests I found resulted in a negative response from JB.

I am looking forward to working with you! Frederik

I confirm the sponsorship of Frederik. I see the discussion already started though but, I'd suggest you guys wait until Sven also confirms. Regards, Giancarlo Razzolini

On Wed, May 06, 2020 at 11:19:04PM +0200, Discussion about the Arch User Repository (AUR) wrote:

Hi everyone, my name is Frederik aka freswa and I'm applying to become a Trusted User with svenstaro's and grazzolini's sponsorship.

I started using Linux around 2004 with some live images of Ubuntu. In 2010, Debian became my main OS. Only a year later I switched to Arch after I screwed up Debian/sid while hunting for the latest kernel. I'm interested in DevOps topics, mail server, C, Rust, Go and newer JVM languages such as Kotlin.

Thanks to svenstaro I've been a bug wrangler since February. You mostly hear from me when I assign bugs to the wrong people from time to time :P

OS contributions: - working on the dovecot-xaps code, providing native Mail.app Apple Push for iOS devices - maintaining and writing PKGBUILDs for the AUR - bug reporting and fixing for several projects

My AUR packages got reviewed recently by eschwartz, svenstaro and alad - thanks :)

If I become a TU, I'd like to focus on the bug tracker until we have a better solution. I'd also like to help out bug fixing when maintainers are busy, away or on vacation.

Packages which I would like to move to [Community], some of which are not mine: docker-credential-pass i3status-rust intel-undervolt ispin mysqltuner pdfposter pinentry-rofi protobuf-go sha3sum spin talosctl thermald unifi woeusb

I'm aware though that some of these packages do not meet the criteria of 10 votes yet. I'll reevaluate whether they meet this criteria from time to time. I'd also like to go on helping Eli with maintenance of zfs-dkms and zfs-utils in the AUR.

In case JetBrains is okay with us packaging their IDE's, I'd also maintain them. But so far all requests I found resulted in a negative response from JB.

I am looking forward to working with you! Frederik

Hi freswa, I would like to ask you the following questions: 1. How do you monitor new software releases? Do you use a specific tool for this like urlwatch? 2. How do you want to participate in the Arch Linux community? I see that you are very active in the IRC and on the bugtracker. Are there other areas, where you are active? 3. Do you use any tools for enforcing a specific PKGBUILD format? For example shfmt? 4. Are you testing your packages? If so, how? Do you spawn a VM via vagrant? Or do you use systemd-nspawn or docker images? Or do you just test it locally on your machine? Thanks chris

On 5/6/20 5:19 PM, Frederik Schwan via aur-general wrote:

Hi everyone, my name is Frederik aka freswa and I'm applying to become a Trusted User with svenstaro's and grazzolini's sponsorship.

I started using Linux around 2004 with some live images of Ubuntu. In 2010, Debian became my main OS. Only a year later I switched to Arch after I screwed up Debian/sid while hunting for the latest kernel.

I'm interested in DevOps topics, mail server, C, Rust, Go and newer JVM languages such as Kotlin.

Thanks to svenstaro I've been a bug wrangler since February. You mostly hear from me when I assign bugs to the wrong people from time to time :P

OS contributions: - working on the dovecot-xaps code, providing native Mail.app Apple Push for iOS devices - maintaining and writing PKGBUILDs for the AUR - bug reporting and fixing for several projects

My AUR packages got reviewed recently by eschwartz, svenstaro and alad - thanks :)

Just for the record -- I did not review your AUR packages, you may have intended to ask me to do so but this never happened. Perhaps you drafted this email and forgot to remove my name before sending it? You did provide a very useful kernel backports patch for my zfs-dkms package, which was much appreciated.

If I become a TU, I'd like to focus on the bug tracker until we have a better solution. I'd also like to help out bug fixing when maintainers are busy, away or on vacation.

I don't know what this means... once there is a "better solution for our bugtracker" you intend to not focus on it? :p Becoming a TU might give more opportunities to commit fixes to packages, but it's unrelated to triage and analysis, at least, which I'd say are the things which need the most love. So there's plenty to do there either way. :D (Speaking from personal experience, being a TU has made me less productive on the bugtracker.)

I'm aware though that some of these packages do not meet the criteria of 10 votes yet. I'll reevaluate whether they meet this criteria from time to time.

I'd also like to go on helping Eli with maintenance of zfs-dkms and zfs-utils in the AUR.

Patches and suggestions are definitely welcome. :D Though I doubt zfs is suitable in any way for inclusion in community, despite indeed having enough votes.

In case JetBrains is okay with us packaging their IDE's, I'd also maintain them. But so far all requests I found resulted in a negative response from JB.

I'm given to understand packaging our current packages for pycharm/intellij community edition gives their current maintainers enough agonizing headaches. It seems like the kind of thing one would want to avoid getting involved in. :D I don't think we should be packaging their custom JRE, anyway, as that should remain an AUR kind of thing (and we don't optdepends on AUR packages either). This probably makes it more complicated to support their stuff, especially for things which aren't open source? tl;dr do you believe this is practical to focus on? Do you think they are likely to provide a way for us to package it which fits our packaging guidelines? -- Eli Schwartz Bug Wrangler and Trusted User

On 5/6/20 11:19 PM, Frederik Schwan via aur-general wrote:

I am looking forward to working with you! Frederik

Hi Frederik, I'm happy to _already_ work with you as you are doing a great job on the bugtracker. I hope we won't loose your power wrangling that beast :D I managed to cut some free time to review all your packages, so here comes the feedback, cheers, Levente $ xxarhtna --user freswa adobe-icc: - could use TLS in url and source, because why not :} - would be a good idea to reuse $pkgver in source=() chisel: - doesn't use a unique source as v$pkgver.tar.gz may exist multiple times. could use githubs full filename endpoint: $url/archive/v$pkgver/$pkgname-$pkgver.tar.gz dovecot-xaps-daemon: - should not have the conflicts, its always the special variants that conflict on the regular variant, not the other way around - doesn't use a unique source as v$pkgver.tar.gz may exist multiple times. could use githubs full filename endpoint: $url/archive/v$pkgver/$pkgname-$pkgver.tar.gz - could use the new set of go binary hardening flags so sources are fortified, pie, etc: CGO_{L,C,CXX,CPP}FLAGS - License is a non common one but the distribution of anything indicating the license is missing. dovecot-xaps-daemon-git: - normally its a bit better to have a pkgver that actually has any meaning in what kind of version the installed pkg matches, like 0.7.r21.b098747 instead of 94.b098747 git describe --tags | sed 's/^v//;s/\([^-]*-g\)/r\1/;s/-/./g' - could use the new set of go binary hardening flags so sources are fortified, pie, etc: CGO_{L,C,CXX,CPP}FLAGS - License is a non common one but the distribution of anything indicating the license is missing. dovecot-xaps-plugin: - build function doesn't build anything, the package functions "make install" will do the real compilation. - Should not makedepend on git as its not using git - should not have the conflicts, its always the special variants that conflict on the regular variant, not the other way around - doesn't use a unique source as v$pkgver.tar.gz may exist multiple times. could use githubs full filename endpoint: $url/archive/v$pkgver/$pkgname-$pkgver.tar.gz - License is a non common one but the distribution of anything indicating the license is missing. - cmake has a convenient "-B build" to that doesn't require mkdir dovecot-xaps-plugin-git: - build function doesn't build anything, the package functions "make install" will do the real compilation. - missing provides and conflicts on the regular non -git variant - normally its a bit better to have a pkgver that actually has any meaning in what kind of version the installed pkg matches, like 0.7.r21.b098747 instead of 94.b098747 git describe --tags | sed 's/^v//;s/\([^-]*-g\)/r\1/;s/-/./g' - License is a non common one but the distribution of anything indicating the license is missing. - cmake has a convenient "-B build" to that doesn't require mkdir duperemove-git: - should not pull over plaintext git:// but git+https to provide endpoint verification and encryption during transit - missing conflicts on duperemove - normally its a bit better to have a pkgver that actually has any meaning in what kind of version the installed pkg matches, like 0.7.r21.b098747 instead of 94.b098747 git describe --tags | sed 's/^v//;s/\([^-]*-g\)/r\1/;s/-/./g' exfat-dkms-git: - shouldn't this also provide something like exfat and exfat-dkms - this shouldn't confict on other special git variant exfat-git - shouldn't this package be named exfat-nofuse-dkms-git ? its not just exfat-dkms, this is in fact exfat-nofuse exfat-utils-nofuse: - non quoted usage of ${srcdir} which may fail if it contains spaces - autoreconf could be executed during prepare step flexbox-udev: - non quoted usage of ${srcdir} and ${pkgdir } which may fail if it contains spaces gimp-plugin-separate+: - modifying or patching files should be done during prepare gtkhotkey: - modifying or patching files should be done during prepare heif: - doesn't use a unique source as v$pkgver.tar.gz may exist multiple times. could use githubs full filename endpoint: $url/archive/v$pkgver/$pkgname-$pkgver.tar.gz jtool-bin: - doesn't use a unique source and should prefix it with $pkgver - package is outdated as v2 exists latex-tuda-ci: - doesn't use a unique source as v$pkgver.tar.gz may exist multiple times. could use githubs full filename endpoint: $url/archive/v$pkgver/$pkgname-$pkgver.tar.gz libpurple-lurch: - should not on every single build side load the whole submodules repos, instead they should be declared in source=() and the paths updated accordingly -- for an exaple look at the mono package - static version must not provides=() its -git counterpart nameinator: - doesn't use a unique source as v$pkgver.tar.gz may exist multiple times. could use githubs full filename endpoint: $url/archive/v$pkgver/$pkgname-$pkgver.tar.gz - could use the new set of go binary hardening flags so sources are fortified, pie, etc: CGO_{L,C,CXX,CPP}FLAGS - must not use 'go get' on a repo as thats not reproducible onivim2: - should not have the conflicts, its always the special variants that conflict on the regular variant, not the other way around onivim2-git: - missing provides and conflicts on the regular non -git variant open-ecard-git: - should not pull over plaintext git:// but git+https to provide endpoint verification and encryption during transit - missing provides and conflicts on the regular non -git variant - it this hard depending on the JRE 8 for a reason, can't this be run on newer JRE? If so, it would need the startup script to hardcode the java jvm path to that specific variant OpenBoardView: - cmake has a convenient "-B build" to that doesn't require mkdir or-tools-java: - doesn't use a unique source as v$pkgver.tar.gz may exist multiple times. could use githubs full filename endpoint: $url/archive/v$pkgver/$pkgname-$pkgver.tar.gz - does this really makedepend on git? It it checking out more stuff? If so it should be revisited to add those repos to the source=() array and popule them otherwise they get downloaded on each run - could use some indention in package() parcimonie-sh-git - pkgdesc looks a bit overly long, should be cut a bit pass-sshaskpass: - should not pull over plaintext git:// but git+https to provide endpoint verification and encryption during transit - pkgname is wrong as this is in fact a -git package, but the name makes it a static version one pdfposter: - repo seems to contain unit tests, would be worth running in a check() function - uses setuptools entrypoing wrapper, therefor python-setuptools is not just a makedepends but a hard requirement perl-ntlm: - seems to lack depends on perl, i hardly doubt a perl module works without a single dependency :) - could use TLS in url and source, because why not :} pinentry-rofi: - missing depends on rofi - doesn't use a unique source as v$pkgver.tar.gz may exist multiple times. could use githubs full filename endpoint: $url/archive/v$pkgver/$pkgname-$pkgver.tar.gz - License is a non common one but the distribution of anything indicating the license is missing. python-requests-gpgauthlib: - doesn't use a unique source as v$pkgver.tar.gz may exist multiple times. could use githubs full filename endpoint: $url/archive/v$pkgver/$pkgname-$pkgver.tar.gz - missing requires on python-gnupg and python-requests - repo seems to contain unit tests, would be worth running in a check() function talosctl: - doesn't use a unique source as v$pkgver.tar.gz may exist multiple times. could use githubs full filename endpoint: $url/archive/v$pkgver/$pkgname-$pkgver.tar.gz - could use the new set of go binary hardening flags so sources are fortified, pie, etc: CGO_{L,C,CXX,CPP}FLAGS - Go packages are not 'any' arch, they are architecture dependent tbt: - cmake has a convenient "-B build" to that doesn't require mkdir - doesn't use a unique source as v$pkgver.tar.gz may exist multiple times. could use githubs full filename endpoint: $url/archive/v$pkgver/$pkgname-$pkgver.tar.gz - any reason why its deleting the documentation in /usr/share/doc? thunderbird-nightly: - this is not a source build and hence must be postfixed with -bin tomighty: - is a static version 0.7.2 but doesn't use a static source, the branch for 0.7 could change at any point. must depend on a non changing state - convert operations should be done during build tpacpi-bat-git: - should not pull over plaintext git:// but git+https to provide endpoint verification and encryption during transit - normally its a bit better to have a pkgver that actually has any meaning in what kind of version the installed pkg matches, like 0.7.r21.b098747 instead of 94.b098747 git describe --tags | sed 's/^v//;s/\([^-]*-g\)/r\1/;s/-/./g' - pkgdesc looks a bit overly long, should be cut a bit wrench: - doesn't use a unique source as v$pkgver.tar.gz may exist multiple times. could use githubs full filename endpoint: $url/archive/v$pkgver/$pkgname-$pkgver.tar.gz - missing depends on python-requests and python-click - uses setuptools entrypoing wrapper, therefor python-setuptools is not just a makedepends but a hard requirement - repo seems to contain unit tests, would be worth running in a check() function xfce-polkit: - autotools stuff should be run during prepare() - should not have the conflicts on -git, its always the special variants that conflict on the regular variant, not the other way around xfce-polkit-git: - autotools stuff should be run during prepare() - normally its a bit better to have a pkgver that actually has any meaning in what kind of version the installed pkg matches, like 0.7.r21.b098747 instead of 94.b098747 git describe --tags | sed 's/^v//;s/\([^-]*-g\)/r\1/;s/-/./g' EOF