Re: [pacman-dev] [PATCH] Add -s --sign and -v --verify to repo-add usage message.

On Fri, Mar 25, 2011 at 6:45 PM, Dan McGee wrote:

On Fri, Mar 25, 2011 at 5:38 PM, Allan McRae wrote:

...

On 26/03/11 08:16, Dan McGee wrote:

...

On Fri, Mar 25, 2011 at 5:14 PM, Ray Kohler  wrote:

...

There were not added to the end of the list as that would mean splitting the single gettext string that contains -f and the "see the man page" message, and I wanted to do as little string damage as possible.

Do string damage, it is a major release. But more importantly, repo-remove --help is going to show these and we might want to try and avoid that- I think the reason they weren't added here.

I think these options are still relevant to repo-remove.

-d and -f? If you remove an entry, the whole darn thing goes, regardless of whether there are deltas or files ...files in there.

That's what checking the code bears out to me as well, but I think Allan's point is that -s and -v actually do apply to repo-remove. While reading through this code, I noticed what looks like a bug - when using repo-remove to remove the very last package ("zip up some emptyness"), the repo won't be signed even if -s was given. Want me to fix that once I'm done with the usage message?