[arch-general] Removing gitolite package doesn't remove gitolite user

[Óscar García Amor]

The main problem is that the _useradd_ is launched with -m parameter that
creates the home directory to gitolite user. If user already exists then
the home directory is not recreated. IMHO is better don't use -m modifier
and do something like this:

if [[ ! -d /var/lib/gitolite ]] ; then
    mkdir /var/lib/gitolite
    chown gitolite:gitolite /var/lib/gitolite
fi

The full install script must be something like this:

post_install() {
  # We need ssh login and thus a valid shell. No way to create
  # the user with sysusers.d(5)?

  getent group gitolite > /dev/null || groupadd \
    -g 196 gitolite

  getent passwd gitolite > /dev/null || useradd \
    -M -u 196 -g gitolite -d /var/lib/gitolite -s /bin/bash gitolite

  if [[ ! -d /var/lib/gitolite ]] ; then
    mkdir /var/lib/gitolite
    chown gitolite:gitolite /var/lib/gitolite
  fi
}

post_upgrade() {
  post_install
}

Take note that -r option is unnecessary since in the script is specifies
the UID and GID.

Greetings.


2017-04-01 4:12 GMT+02:00 Ricardo Band <email at ricardo.band>:

> On Fri, 2017-03-31 at 20:37 -0500, Doug Newgard wrote:
> >
> > Short version here, you deleted the user's home dir manually and left
> > the user.
> > That's not a packaging problem.
>
> Yep. But shouldn't the home dir be recreated when I reinstall the
> package?
> It seems that the package only executes a useradd command that creates
> the user home. If the user already exists that command seems to return
> true without recreating the home.
>
> The package could check for the dir after that and if it's not there
> create it. The package method in the PKGBUILD already includes the
> creation of the directory but it doesn't seem to fire if the user is
> already there. Which is a bit weird because I don't see any check for
> the user in there [1].
>
> [1]: https://git.archlinux.org/svntogit/community.git/tree/trunk/PKGBUI
> LD?h=packages/gitolite
>
> --
>
> Greetings
>
> Ricardo Band
>
>  https://   www.ricardo.band
> mailto:// email at ricardo.band
>



-- 
Óscar García Amor | ogarcia at moire.org | http://ogarcia.me