[arch-releng] Iso tests

[Tom Willemsen]

Hey guys,

I thought I might send another status report.

> * Rollback section -> let's remove the select button, it's a bit redundant.  Instead you can put the text "If you did a rollback followed by a new attempt to setup your blockdevices/filesystems, select which option you took here"
> * make it more clear users should fill in the "rollback modules" section only if they did a rollback.
> you can then also remove the (useless?) rollback part that has yes/no but no dates, on the main page.
Did this, and placed some help text underneath the 2 rollback option
lists (rollback_filesystem and rollback_modules)

> * "success" -> clearly tell users only to flag this if everything worked fine, and they can fill in comments if anything specific failed.
Added some help text to it, hope that's ok.

> * "modules" -> let's also add ext, swap, xfs, jfs and reiserFS.
Added these, though I used ext2, ext3, ext4, hope that's ok (and the
other of course).

> * the two modules checklists should come before success/comments. i.e. success/comments should be the last thing on the page.
Also done.

> * after i hit submit, i saw again the http://localhost:8000/isotests/ page, but everything was still "never failed" / "never succeeded".
> then i reloaded the page and saw the results of my input?
> either way, it would be useful to tell the user, after submitting "thanks, submission worked", or the same form again with the reasons why the submission failed (i believe they call this form validation [feedback])
I've never run into this, and I did try. But hopefully now it won't
matter, when someone fills the form in completely they're redirected to
a 'thanks' page and from there they can click go back to results or give
more feedback.

> * I didn't select any modules in the rollback modules part, but the mainpage shows successes for the same modules as the ones I flagged in the regular "modules" checklist.
Yeah there is something going on here. I (apparently) forgot to include
a function for getting the rollback modules and filesystems instead of
the regular ones. Now I did, but I'm being plagued by the form not
updating the values correctly. Since the Test class has 2 references to
the Filesystem and Modules classes each it uses the related_name
property to distinguish them, but using this in a form seems
troublesome, when I click some options they don't get saved, I've been
looking into this, but so far no luck except, maybe the problem is that
I customize the rollback_filesystem and rollback_modules and it forgets
to use its related_name this way, I don't know.

> * add some links between all the pages. I know you said you would like it to be nicely themed and everything, and I think that's a good idea, but that shouldn't be a blocking factor, for all I care you can make the links as ugly as they can get [for now], as long as they work.
Did this, and even though I didn't do anything to them I almost like the
way they look.

> * in the success/failed colums of /isotests/, if they are filled in (with an isoname) I want that isoname to be a link, so that when I click on it, I see a list of all feedbacks from users of this specific point. For example it would look like:
I'm still working on this, I was thinking though, wouldn't you prefer
the iso name to take you to a list of the results of that iso and the
names of the properties to take you to a list of results for that
property (as described below)?
> 
> Results for : image boot: optical
> 
> iso - nickname - success?
> 2011.03.23 - Dieterbe - Y
> 2011.03.13 - Tom      - N
> (...)

I still need to get that wiki page up, need to read the style rules
first, I'll do that tomorrow and I'll work on the points left as well.

Tom