[aur-general] maynard-git package review request

Alive 4ever alive4ever at live.com
Mon Aug 22 09:47:51 UTC 2016


On Sun, Aug 21, 2016 at 11:15:16PM -0400, Eli Schwartz via aur-general wrote:
> To quote the Wiki[1]...
> 
> Both methods can also be combined, to support repositories that start
> without a tag but get tagged later on (uses a bashism):
> 
> ```
> pkgver() {
>   cd "$pkgname"
>   ( set -o pipefail
>     git describe --long 2>/dev/null | sed 's/\([^-]*-g\)/r\1/;s/-/./g' ||
>     printf "r%s.%s" "$(git rev-list --count HEAD)" "$(git rev-parse
> --short HEAD)"
>   )
> }
> ```
For now, I'll stick to use no-tag version. Tagged version will be
considered when the time comes.
> 
> > I think configure flag --libexecdir is needed to put maynard executable
> > under /usr/lib/maynard. Without libexecdir, the resulting executable is
> > placed under /usr/libexec/maynard and it's kind of messy.
> > 
> > I should have tested the PKGBUILD under clean chroot to specify exact
> > dependencies.
> > 
> > Thanks for your feedback.
> > 
> 
> Hmm, maybe -- I haven't tried it, so I wouldn't know. But libexecdir
> does ring a bell...
> What about bindir, libdir, and sysconfdir though? IIRC those should
> already have the right default values.

Removing bindir, libdir, and sysconfdir flags creates no problems so
far. It put the binaries and libraries in the right place according to
Arch Linux packaging standards.

> 
> -- 
> Eli Schwartz
> 
> 
> [1] https://wiki.archlinux.org/index.php/VCS_package_guidelines#Git


More information about the aur-general mailing list