[aur-general] TU application: Maxim Baz

[Levente Polyak]

Hi Maxim,

some feedback to your packages that others did not yet bring up (so
pelase go through jelle's as well, i did not include them again):

But before we start, can't resist mumbling a small 'meh' for all this
non build content hosted in the AUR. meh.


browserpass:
- just a nitpick, but entry point is always $srcdir so if there is no
  reason to do so, its just line-noise when calling 'cd' on each step.

chromium-vaapi:
- just the same tiny nitpick about cd-ing into $srcdir

chromium-vaapi-bin:
- this should also provide chromium-vaapi

grub-btrfs:
- conflicts on a git variant doesn't belong here. always the
  other way around
- sources must be unique when f.e. stored in a global place,
  always prefix artifacts like v$pkgver.tar.gz with
  $pkgname-$pkgver.tar.gz::
- no need to distribute GPL3 license, they are common and therefore
  nothing put storage waste.

i3ipc-python:
- don't provide yourself, doesn't do anything
- conflicts on a git variant doesn't belong here. always the
  other way around
- same tiny nitpick about cd-ing into $srcdir
- upstream has tests, why not call whem via checkdepends and py.test?

kak-lsp:
- someone should push a non git go-langserver so this packages doesn't
  need to recommend an optdepends on a git package
- same tiny nitpick about cd-ing into $srcdir

lscolors-git
- should pull over TLS via git+https://
- should have proper provides/conflicts
- still not a fan of those verbose docs in .install

rmtrash
- ok at least im sure this .install classifies as not mandatory
  for a package to work, right? :P
- just the same tiny nitpick about cd-ing into $srcdir
- this is bash, it should have arch=(any)

wire-desktop
- conflicts on a -bin variant doesn't belong here. always the
  other way around
- this source prefix is literally useless it should be unique
  like  $pkgname-$pkgver.tar.gz::
- same tiny nitpick about cd-ing into $srcdir
- patching should be done in prepare()
- ending pkgdesc with a dot is meh
- hunspell-en optdepends does not exist

wire-desktop-beta:
- conflicts is total bogus, should only have 'wire-desktop' as
  does provides
- this source prefix is literally useless it should be unique
  like  $pkgname-$pkgver.tar.gz::
- same tiny nitpick about cd-ing into $srcdir
- patching should be done in prepare()
- ending pkgdesc with a dot is meh
- hunspell-en optdepends does not exist

wire-desktop-git:
- makedepends on git is missing
- should pull via git+https over TLS
- conflicts is bogus, should only have 'wire-desktop' as
  does provides
- same tiny nitpick about cd-ing into $srcdir
- hunspell-en optdepends does not exist

yubikey-touch-detector:
- should be build via go-pie


cheers,
Levente

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/aur-general/attachments/20181106/50475570/attachment-0001.asc>