[pacman-dev] [patch] testdb, reworked

Aaron Griffin aaronmgriffin at gmail.com
Tue Oct 9 11:42:35 EDT 2007


On 10/9/07, Nagy Gabor <ngaba at bibl.u-szeged.hu> wrote:
> Hi!
> I had to rewrite the patch, because I found a new bug in testdb.c:
> Using alpm_list_msort broke requiredby lists in pkgcache (you can test this by
> duplicating the requiredby-test code), so I fixed this, too.
> Patch attached, bye.

Great! Thanks a lot for the patch - this looks good to me.

My only qualm is that we've set the precedent of using _alpm_* for
internal functions, so check_conflict should probably use the same
prefix.

Dan?




More information about the pacman-dev mailing list